![]() ![]() The only thing I can promise to you is that I will review the patch when it is updated. I'm a software engineer at Google, so unfortunately I can't keep putting time aside to integrate with the HEAD. I really, really recommend that you take the time to integrate these changes in - I think a lot of your time would be saved not only in not having to fix bugs that I already fixed, but also in tracing new bugs. In addition to fixing various issues, my code changes introduce a new line-wrapping algorithm that doesn't use exception throwing (and keeps a state of the line being output), which makes it a lot easier to track issues & fix bugs. I am willing to integrate my change to the HEAD of eclipse (what I assume will become 3.7) and re-submit a patch, but I would like to know that this time these changes will be integrated, and not just have to be re-merged down the line. I am currently applying my changes to the release version of 3.6, and unfortunately it seems there are a lot of conflicts as a lot of hacky attempts were made to fix reported bugs using the current exception-throwing model. Waiting for my review, I'd appreciate that you update the patches with the last version of JDT/Core and JDT/UI code to make the review easier when I'll start it. So, please be patient and be sure that I'll do it to be ready to integrate it, if it's OK of course, early 3.7. I just had a very quick look on your patch and it seems really interesting, hence I'll review it but may be not before the middle of May. Unfortunately, I had no time to look at those big patches until then and surely will not have time to do so until the workload on last 3.6 milestones does not go down a little bit. > I am more than happy to fix any issues caused by my changes, just point me to a > though, and my fix was a general algorithm change to fix a large array of > have trampled over some of these changes. > As it turns out, some of my fixes had been done by other submitters, so I may > This is my first patch submission to Eclipse, so be gentle :) ![]() > Submitted patch files based on head Eclipse source for both core and ui. Patch for formatter with corrected API versionsĬumulative patch for formatter fix and tests Patch for which contains more flexible preferences for formatter Sample Java file that formats horribly using 100-character lines ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |